-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IDE doc for better auto-completion #774
Conversation
I always thought that // my ST3 cannot into autocomplete, so maybe i'm just wrong :) |
1 similar comment
I just tried and I can confirm that $this work as well :). I like static because it is coherent with how late-state binding works, but I'm open to change that to $this. Let's let @ruflin decide :D. |
I wasn't even aware that PHPStorm is now able to use static or $this for auto complete. I quite like "$this" as it describes very well what it actually is. In which IDE's is this going to work? |
I'm pretty sure NetBeans take advantage of that! |
Eclipse confirmed also |
I've updated to modify static to $this! |
2 similar comments
Fix IDE doc for better auto-completion
Merged. Thx. |
On modern IDE (at least on PHPStorm), returning static allows to let the IDE resolve on real-time based on the caller type. This is necessary if we still want to have nice autocompletion with the fluent interface. I've only fixed that for param and aggregations, I'll do another PR in the future if I find other cases :)